]> dgit.raspbian.org Git - gnome-shell.git/commit
shell-app-system: Do not compare startup-wm classes with full desktop IDs
authorMarco Trevisan (Treviño) <mail@3v1n0.net>
Thu, 23 Mar 2023 23:02:16 +0000 (00:02 +0100)
committerMarge Bot <marge-bot@gnome.org>
Thu, 20 Apr 2023 15:11:58 +0000 (15:11 +0000)
commite7a09946ca44a4f4fae6fa847f08e681cfd877cb
treeb56cc54335399a3fa8427ac53def94cbcf638cae
parent8d1fe3b4cbf5edd025ea28ce56c7659fc22e2937
shell-app-system: Do not compare startup-wm classes with full desktop IDs

When fetching the desktop ids into a map of startup-wm classes we meant
to give the ones that match the desktop ID more priority, however
this did not happen because we were always comparing a desktop
file id, including the `.desktop` suffix, with a wm-class that generally
does not include that.

This is the case of gnome-system-monitor, that provides two desktop
files, one of which is OnlyShowIn=KDE but both have the same
StartupWMClass and thus the first parsed is preferred, even though its
desktop-id is gnome-system-monitor-kde.

As per this, remove the .desktop suffix when comparing it with the
startup-wm-class, keeping the old check just in case.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2721>
src/shell-app-system.c